usb: cdns3: fix use-after-free in cdns3_gadget_exit()

Overview

In the Linux kernel, the following vulnerability has been resolved:

usb: cdns3: fix use-after-free in cdns3_gadget_exit()

cdns3_gadget_start() arms two works on system_freezable_wq: pending_status_wq for the deferred ep0 status stage and aligned_buf_wq for realigned request buffers. Both handlers use the cdns3_device the works are embedded in, and cdns3_pending_setup_status_handler() also calls the ep0 request completion.

cdns3_gadget_exit() does not wait for these works. It frees all endpoints and aligned buffers and drops the last reference to the gadget device, which frees priv_dev, so a work queued before the exit can run after the free.

Fix this by waiting for both works after the gadget driver is unbound and the IRQ is freed, when no new work can be queued, and before the endpoints and buffers are released.

This issue was found by an in-house static analysis tool.

Affected

• Linux >= 7733f6c32e36ff9d7adadf40001039bf219b1cbe < cc448700db656cceb4b411bf99a2e7132144d035
• Linux >= 7733f6c32e36ff9d7adadf40001039bf219b1cbe < 95160fe606e685ff18de1e6ddcbc08289476004e
• Linux >= 7733f6c32e36ff9d7adadf40001039bf219b1cbe < 159dada48ee2d53eff46e66a8011d67b2c209bbc
• Linux >= 7733f6c32e36ff9d7adadf40001039bf219b1cbe < ebe9b68c396792c15d0ac690d592e449e74ed804
• Linux 5.4

Remediation

Refer to the linked advisories for vendor-supplied fixes and affected version ranges.