thunderbolt: Fix NULL dereference in tb_remove_work()

Overview

In the Linux kernel, the following vulnerability has been resolved:

thunderbolt: Fix NULL dereference in tb_remove_work()

There is a slight race between tb_remove_work() and tb_domain_remove() which leads to dereferencing a NULL tb->root_switch pointer inside tb_free_unplugged_xdomains():

    Thread A                            Thread B

tb_remove_work() tb_domain_remove() mutex_lock(&tb->lock) tb_stop() /* doesn't cancel a running callback / cancel_delayed_work(&tcm->remove_work) ... tb_switch_remove(tb->root_switch) tb->root_switch = NULL mutex_unlock(&tb->lock) mutex_lock(&tb->lock) ... / without checking ->root_switch */ tb_free_unplugged_xdomains(tb->root_switch) mutex_unlock(&tb->lock)

Commit a8937f35cf39 ("thunderbolt: Remove XDomain from the bus without holding tb->lock") doesn't seem right to move tb_free_unplugged_xdomains() out of the &tb->lock section and the check for tb->root_switch, in particular. It states:

For this reason separate removing the XDomain from the topology data structures (where we need the lock) from unregistering the device from the bus (where remove callbacks of the drivers are being called).

tb_free_unplugged_xdomains() belongs to the former group of functions requiring the lock. And it also calls tb_xdomain_remove() which should only be called with &tb->lock held.

Found by Linux Verification Center (linuxtesting.org) with Svace static analysis tool.

Affected

• Linux >= a8937f35cf39c39c64325aa84d0463d866850857 < 2f4cd43faa9d6470b30a9fbcbac6584db8108c1f
• Linux >= a8937f35cf39c39c64325aa84d0463d866850857 < 4310c6b8e75d6a47f7548e5948fbe6318aa4440a
• Linux 3e9e823810b9a51f0bee9ed6e3d90df70484ff8d
• Linux 9363cd4977260bf7f211feee54f85858bba2320c
• Linux >= 5.10.266 < 5.11
• Linux >= 5.15.217 < 5.16
• Linux 7.2

Remediation

Refer to the linked advisories for vendor-supplied fixes and affected version ranges.