net/sched: act_ct: fix helper UAF due to extensions realloc

Overview

In the Linux kernel, the following vulnerability has been resolved:

net/sched: act_ct: fix helper UAF due to extensions realloc

While calling the helpers, a raw pointer to the extensions area is wired into expectations list:

-> nf_ct_helper() -> helper->help() -> nf_ct_expect_related_report() -> nf_ct_expect_insert() -> hlist_add_head_rcu(&exp->lnode, &master_help->expectations)

In case the connection is not confirmed yet, more extensions can be added afterwards with *_ext_add() calls reallocating the extension space and leaving the now invalid pointer in the expectations list that is later accessed while removing the expectation.

Make sure that helpers are called at the end after all the other extensions are already added.

Note that the helper rejection now leaves the mark and labels set, but that's not different from how the NAT was handled before or how the mark and the labels were handled on confirmation failure. And there are no atomicity guarantees provided by the API anyway.

Affected

• Linux >= a21b06e7319129994f339ed47f512bbe57b77f5b < 1679bbf5fbeac52a310b1a58b2b301bbf388bdbf
• Linux >= a21b06e7319129994f339ed47f512bbe57b77f5b < 812c16a255e7773a544e88b39ae6daed25544d30
• Linux >= a21b06e7319129994f339ed47f512bbe57b77f5b < 8988f4d11f3fba0ab38122178836c683ad516a05
• Linux >= a21b06e7319129994f339ed47f512bbe57b77f5b < dad19b59da050cb60d3f7023dac2a042a84bf0bd
• Linux 6.2

Remediation

Refer to the linked advisories for vendor-supplied fixes and affected version ranges.