HID: nintendo: stop device IO before hid_hw_stop on probe failure

Overview

In the Linux kernel, the following vulnerability has been resolved:

HID: nintendo: stop device IO before hid_hw_stop on probe failure

nintendo_hid_probe() calls hid_device_io_start() before joycon_init() and joycon_leds_create(). If either fails, the error path jumps to err_close which calls hid_hw_close()/hid_hw_stop() without first calling hid_device_io_stop().

hid_hw_stop() does not stop device IO, so hid_input_report() may still run and access driver data that is being torn down, resulting in a use-after-free.

Add an err_io_stop label that calls hid_device_io_stop() before hid_hw_close(), and point the two post-io_start error paths at it.

Affected

• Linux >= 2af16c1f846bd60240745bbd3afa13d5f040c61a < c2f3d51c7f5222f5b51e0c90f02258d82e1b44dd
• Linux >= 2af16c1f846bd60240745bbd3afa13d5f040c61a < c023443f0e6cfd257846b6515c93c1ea08026593
• Linux >= 2af16c1f846bd60240745bbd3afa13d5f040c61a < 03a84f9f88b42cd49752ec0259922b67e4b88598
• Linux >= 2af16c1f846bd60240745bbd3afa13d5f040c61a < 5efcd7bbfaaec67d137c99aa0940fa34375db27f
• Linux >= 2af16c1f846bd60240745bbd3afa13d5f040c61a < 13a3edf96568a0b7aacadea07c2adec53ac8f630
• Linux >= 2af16c1f846bd60240745bbd3afa13d5f040c61a < 2e0d98dc8a6dea5fc2b72bf66e0dcbd5488644b4
• Linux >= 2af16c1f846bd60240745bbd3afa13d5f040c61a < 1f74d3bff6fe04a64e02ab3661d2e0d554565aa6
• Linux 5.16

Remediation

Refer to the linked advisories for vendor-supplied fixes and affected version ranges.