libceph: fix multiple unsafe decodes in decode_locker()

Overview

In the Linux kernel, the following vulnerability has been resolved:

libceph: fix multiple unsafe decodes in decode_locker()

decode_locker() in cls_lock_client.c contains three unsafe decode operations that allow a malicious or compromised OSD to trigger slab-out-of-bounds reads:

1. ceph_decode_copy() at the locker_id_t name field has no preceding bounds check. With p == end after ceph_start_decoding() accepts struct_len=0, this reads sizeof(ceph_entity_name) = 9 bytes past the validated buffer boundary.

2. *p += sizeof(struct ceph_timespec) after the locker_info_t header is an unchecked pointer advance. A malicious OSD can position p past end, causing all subsequent _safe checks to pass against a bogus boundary.

3. len = ceph_decode_32(p) has no preceding bounds check, and the immediately following *p += len is uncapped. A malicious OSD can send len=0xffffffff, advancing p gigabytes past end and escaping the decode window entirely.

Fix all three by replacing bare operations with their safe variants: ceph_decode_copy -> ceph_decode_copy_safe *p += sizeof(...) -> ceph_decode_skip_n ceph_decode_32(p) -> ceph_decode_32_safe *p += len -> ceph_decode_skip_n

A new label is added to return -EINVAL on any bounds violation. -EINVAL is appropriate here: the data received from the OSD is structurally malformed, which is an invalid argument to the decode contract regardless of whether the caller or the wire is at fault.

Attacker model: a malicious or compromised OSD in a multi-tenant Ceph deployment can trigger this against any kernel client that issues the lock.get_info class method (e.g. during RBD exclusive lock acquisition) without any further privileges beyond OSD session establishment.

[ idryomov: use ceph_decode_skip_string() to skip description, trim changelog ]

Affected

• Linux >= d4ed4a530562881cc5225050e42d96034f405aae < 1ed45c8d96498725eb54f740172f9068d8673906
• Linux >= d4ed4a530562881cc5225050e42d96034f405aae < 6265103e78f0ee7e2518de9cf938b94bee9700a0
• Linux >= d4ed4a530562881cc5225050e42d96034f405aae < 3c3716dc06a34e4ca7f743f5fcfa07fbc5a11070
• Linux >= d4ed4a530562881cc5225050e42d96034f405aae < fa4aa86fff0c56799c2e3f51a88879053285f4a9
• Linux >= d4ed4a530562881cc5225050e42d96034f405aae < dbfd83f722a78446ec18a476ef7a38e52240b50a
• Linux >= d4ed4a530562881cc5225050e42d96034f405aae < d1bba38574d095f191557d397d9633f08cd966b1
• Linux >= d4ed4a530562881cc5225050e42d96034f405aae < 51c8d238fe7236de627ab1a1433694552a904136
• Linux >= d4ed4a530562881cc5225050e42d96034f405aae < 437b6551cfcc235eea1d735a874f9d421f555e17
• Linux 4.9

Remediation

Refer to the linked advisories for vendor-supplied fixes and affected version ranges.