dm: avoid leaking the caller's thread keyring via the table device file

Overview

In the Linux kernel, the following vulnerability has been resolved:

dm: avoid leaking the caller's thread keyring via the table device file

The refactoring in commit a28d893eb327 ("md: port block device access to file") accidentally causes the caller's thread keyring to be kept alive long beyond the caller's lifetime.

As a result, "cryptsetup luksSuspend" silently fails to wipe the LUKS volume key from memory.

In detail: "cryptsetup luksOpen" uses its supposedly ephemeral thread keyring to pass the volume key to the kernel. dm-crypt's crypt_set_keyring_key() copies the key material into its own crypt_config structure and then drops its own reference to the key in the keyring with key_put().

With this fix, restoring pre-v6.9 behavior, the copy in the thread keyring is then promptly garbage collected, such that exactly one copy of the volume key remains. This single copy is correctly wiped from memory on "cryptsetup luksSuspend".

Without this fix, the thread keyring and the volume key in it remains. This second copy is only freed on "luksClose". "luksSuspend" neither knows about this copy nor has any way to remove it, so the key remains recoverable from RAM after a suspend that is documented to have wiped it.

This fix should not introduce new security problems, as the code is anyway gated by CAP_SYS_ADMIN. The device-mapper core, not the calling task, is the legitimate owner of this long-lived file.

Affected

• Linux >= a28d893eb3270cf62c10dd8777af0d8452cdc072 < d3eb8451d529ea452740d1a2bc395a1d20c48133
• Linux >= a28d893eb3270cf62c10dd8777af0d8452cdc072 < 8ced1d242c34e342defcccdb00663354f212aae6
• Linux >= a28d893eb3270cf62c10dd8777af0d8452cdc072 < f00105be6a593920e9bc7949a069d4a116888851
• Linux >= a28d893eb3270cf62c10dd8777af0d8452cdc072 < 981ccd97f7153d310dfa92a534525bbaf46752c2
• Linux 6.9

Remediation

Refer to the linked advisories for vendor-supplied fixes and affected version ranges.