ovl: check access to copy_file_range source with src mounter creds

Overview

In the Linux kernel, the following vulnerability has been resolved:

ovl: check access to copy_file_range source with src mounter creds

Commit 5dae222a5ff0c ("vfs: allow copy_file_range to copy across devices") allowed filesystems that implement the copy_file_range() f_op to decide if they want to access cross-sb copy from/to the same fs type.

The same commit added checks to verify same sb copy for filesystems that implement ->copy_file_range() and do not support cross-sb copy at the time, namely, to ceph, fuse and nfs.

The two remaining fs which implement ->copy_file_range(), cifs and overlayfs started to support cross-sb copy from this time.

While overlayfs does support cross-sb copy when the two underlying files are on the same base fs, the copy operation on the two real files from two different overalyfs filesystems is performed with the mounter creds of the destination overlayfs and the read permission access hook for the source file was called with the wrong creds.

This could cause either deny of access to copy which would otherwise be allowed (e.g. with splice) or allow read access to file which would otherwise be denied.

Fix the latter case by explicitly verifying read access to source file with the source overlayfs mounter creds.

The former case remains a quirk of cross-sb overlayfs copy, but userspace could fall back to regular copy so no harm done.

Affected

• Linux >= 5dae222a5ff0c269730393018a5539cc970a4726 < 7e13e5b087375f1aee1e930503d20efa7084c0fa
• Linux >= 5dae222a5ff0c269730393018a5539cc970a4726 < 46c296aa678828105842eee29a147508d803d926
• Linux >= 5dae222a5ff0c269730393018a5539cc970a4726 < 9ec22c8113d8cf72ed7197bb61037dcad09e50d8
• Linux >= 5dae222a5ff0c269730393018a5539cc970a4726 < 1f4a107439d2e43db176e34919933e617cb7f2c5
• Linux >= 5dae222a5ff0c269730393018a5539cc970a4726 < a1e0eb8f55cfe09bb31a202a388babc411292656
• Linux 5.3

Remediation

Refer to the linked advisories for vendor-supplied fixes and affected version ranges.