drm/amdgpu: Fix context pstate override handling

Overview

In the Linux kernel, the following vulnerability has been resolved:

drm/amdgpu: Fix context pstate override handling

There are several problems in the context pstate handling code.

The most serious ones are potential use-after-free and NULL pointer dereferences at context initialization time. Both are due amdgpu_ctx_init() not holding the adev->pm.stable_pstate_ctx_lock, which is otherwise used from both sysfs and the context code itself for modifying and clearing the stored context pointer.

Second issue is that context fini can trample over the pstate configuration set via sysfs. This is due the restore state (ctx->stable_pstate) being saved at context init time, and not if, or when the context actually changes the pstate. As the context exits it will therefore incorrectly restore to what was set before the sysfs override was requested.

The simplest fix is to drastically simplify how the state is tracked, by clearly defining the points at which pstate ownership is taken and released, and to handle all transitions under the correct lock.

Instead of at context init time, the previous state is saved only at the point the context overrides the current state, and is restored on context exit only if the context is still the owner of the current override state.

(cherry picked from commit 1b5e413713c0a93bc1818394d0ce49aaad21bd27)

Affected

• Linux >= 79610d3041338dc1ef554d6fd8b3b3e23be527f5 < 23a8726e1d7597fe7c9a59d5dc42ba8b7d345b8a
• Linux >= 79610d3041338dc1ef554d6fd8b3b3e23be527f5 < e06c39cc1c48dca68a5ffd971c23025a52d46634
• Linux >= 79610d3041338dc1ef554d6fd8b3b3e23be527f5 < 9f9c88eb298c54348be3ca4087f4f4c615065b87
• Linux >= 79610d3041338dc1ef554d6fd8b3b3e23be527f5 < c1dc4ccb82c9e56325d8e7514ca4c90bd1efb351
• Linux 6607901fce79959130db485e7549dacaaeef034e
• Linux >= 6.0.7 < 6.1
• Linux 6.1

Remediation

Refer to the linked advisories for vendor-supplied fixes and affected version ranges.