xwiki-pro-macros has remote code execution from page title and content via excerpt-include macro

Overview

Summary

The excerpt-include macro does not properly escape the title of the included page and executes the content of the excerpt with the macro's rights. Therefore, it is vulnerable to XWiki syntax injection via the included page's title and content, allowing remote code execution for any user who can edit a page.

Details

The title of the included page isn't escaped in ExcerptInclude.xml#L277. Further, the content of the excerpt macro is rendered to XWiki syntax and output into the macro's content such that it is executed with the macro's rights.

PoC

1. As a user without script or programming right, create a page named Exploit.
2. In the edit screen, change the title to {{async}}{{groovy}}println("Hello from Groovy Title!"){{/groovy}}{{/async}}.
3. Set the content to

{{excerpt-include 0="Exploit.WebHome"}}{{/excerpt-include}}

{{excerpt}}
  {{async}}{{groovy}}println("Hello from Groovy content!"){{/groovy}}{{/async}}
{{/excerpt}}

4. Save and view the page.
5. If this displays "Hello from Groovy Title!" without the surrounding macro code or "Hello from Groovy content!", the attack succeeded.

Impact

Remote code execution impacts the confidentiality, integrity and availability of the whole XWiki installation.

Affected packages

• com.xwiki.pro:xwiki-pro-macros >= 1.13, < 1.14.5

Remediation

Upgrade to a patched release:

• com.xwiki.pro:xwiki-pro-macros 1.14.5