Electron: HID and USB permission checks can be attributed to the wrong origin

Overview

Impact

For hid and usb permission checks made from an iframe, session.setPermissionCheckHandler was given the top-level frame's origin and details instead of the requesting frame's. Apps that allow these permissions based on origin could grant an embedded frame access intended for the top-level page.

You're only affected if you use setPermissionCheckHandler with origin-based logic for hid or usb and embed cross-origin iframes with allow="hid" or allow="usb". Apps that don't delegate those features to untrusted iframes are not affected.

Workarounds

Don't add allow="hid" / allow="usb" to untrusted iframes, or make the decision in your select-hid-device / select-usb-device handler using details.frame.

Fixed Versions

• 45.0.0-alpha.5
• 44.3.0
• 43.7.0
• 42.11.3

For more information

If you have any questions or comments about this advisory, email us at [email protected]

Affected packages

• electron >= 45.0.0-alpha.1, < 45.0.0-alpha.5
• electron >= 44.0.0-alpha.1, < 44.3.0
• electron >= 43.0.0-alpha.1, < 43.7.0
• electron < 42.11.3

Remediation

Upgrade to a patched release:

• electron 45.0.0-alpha.5
• electron 44.3.0
• electron 43.7.0
• electron 42.11.3