espintcp: remove encap socket caching to avoid reference leak

Overview

In the Linux kernel, the following vulnerability has been resolved:

espintcp: remove encap socket caching to avoid reference leak

The current scheme for caching the encap socket can lead to reference leaks when we try to delete the netns.

The reference chain is: xfrm_state -> enacp_sk -> netns

Since the encap socket is a userspace socket, it holds a reference on the netns. If we delete the espintcp state (through flush or individual delete) before removing the netns, the reference on the socket is dropped and the netns is correctly deleted. Otherwise, the netns may not be reachable anymore (if all processes within the ns have terminated), so we cannot delete the xfrm state to drop its reference on the socket.

This patch results in a small (~2% in my tests) performance regression.

A GC-type mechanism could be added for the socket cache, to clear references if the state hasn't been used "recently", but it's a lot more complex than just not caching the socket.

Affected

• Linux >= e27cca96cd68fa2c6814c90f9a1cfd36bb68c593 < e32bafd08ee35feacd47b05cc5bfe9cd9659cd25
• Linux >= e27cca96cd68fa2c6814c90f9a1cfd36bb68c593 < 9673ca00e6c5503069dc98780e2e89db0e663c16
• Linux >= e27cca96cd68fa2c6814c90f9a1cfd36bb68c593 < e4cde54b46a87231c77256a633be1bef62687d69
• Linux >= e27cca96cd68fa2c6814c90f9a1cfd36bb68c593 < b58a295d10065960bcb9d60cb8ca6ead9837cd27
• Linux >= e27cca96cd68fa2c6814c90f9a1cfd36bb68c593 < 9cbca30102028f9ad3d2098f935c4368f581fd07
• Linux >= e27cca96cd68fa2c6814c90f9a1cfd36bb68c593 < 74fd327767fb784c5875cf7c4ba1217f26020943
• Linux >= e27cca96cd68fa2c6814c90f9a1cfd36bb68c593 < 028363685bd0b7a19b4a820f82dd905b1dc83999
• Linux 5.6

Remediation

Refer to the linked advisories for vendor-supplied fixes and affected version ranges.