{"id":"GHSA-j5mc-p8qg-39j7","title":"Kimai Favorite Timesheet Add and Remove Endpoints Allows Cross-User Bookmark Manipulation","summary":"Kimai Favorite Timesheet Add and Remove Endpoints Allows Cross-User Bookmark Manipulation","severity":"low","cwe":["CWE-639","CWE-862"],"vendor":"kimai","product":"kimai/kimai","ecosystem":"composer","affected":["kimai/kimai <= 2.56.0"],"patched":["kimai/kimai 2.57.0"],"published":"2026-07-02","updated":"2026-07-02","source":"GHSA","sourceUrl":"https://github.com/advisories/GHSA-j5mc-p8qg-39j7","references":[{"url":"https://github.com/kimai/kimai/security/advisories/GHSA-j5mc-p8qg-39j7"},{"url":"https://www.kimai.org/en/security/ghsa-j5mc-p8qg-39j7"},{"url":"https://github.com/advisories/GHSA-j5mc-p8qg-39j7"}],"tags":["ghsa","composer"],"ingestedAt":"2026-07-02T21:44:45.104Z","slug":"GHSA-j5mc-p8qg-39j7","body":"## Overview\n\n### Summary\n\nKimai 2.56.0 contains an authenticated improper authorization / IDOR vulnerability in the favorite timesheet add and remove endpoints. A low-privileged user who knows another user's `timesheet.id` can add that record to, or remove it from, the victim's `favorite/recent` bookmark list. This allows cross-user manipulation of per-user favorite state without administrative privileges.\n\n### Details\n\nThe issue affects the following routes:\n\n- `GET /en/favorite/timesheet/add/{id}`\n- `GET /en/favorite/timesheet/remove/{id}`\n\nBoth endpoints accept a user-controlled timesheet identifier and only require the caller to hold the generic `start_own_timesheet` permission. They do not verify that the referenced `Timesheet` object belongs to the currently authenticated user.\n\n- In `src/Controller/FavoriteController.php`, the controller methods accept a `Timesheet` object directly and forward it to the favorite service. \n- The root cause becomes more obvious in `src/Timesheet/FavoriteRecordService.php`. The bookmark owner is derived from `$timesheet->getUser()` instead of the current session user.\n- Because of this design, any authenticated user who can reference another user's timesheet ID can modify the victim's `favorite/recent` bookmark data.\n\n*A PoC was provided, but removed for security reasons.*\n\n### Impact\n\nThis vulnerability allows any authenticated low-privileged user to manipulate another user's favorite bookmark state across accounts. An attacker can inject arbitrary victim-owned timesheet entries into the victim's quick-entry workflow, remove existing favorites, and repeatedly disturb the victim's normal timesheet usage without needing administrative privileges.\n\nThe issue does not directly disclose sensitive data, but it is a real cross-user business-state tampering vulnerability with clear integrity impact. Because the add and remove endpoints can be combined, an attacker can reliably insert, remove, and reorder entries in another user's `favorite/recent` list.\n\n## Affected packages\n\n- `kimai/kimai <= 2.56.0`\n\n## Remediation\n\nUpgrade to a patched release:\n\n- `kimai/kimai 2.57.0`","depth":"sunlit","depthScore":14,"depthScoreParts":{"impact":13.8,"likelihood":0,"exploitation":0,"ransomware":0},"changes":[]}